Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectors may start with combinators #279

Merged
merged 2 commits into from
Sep 2, 2022
Merged

selectors may start with combinators #279

merged 2 commits into from
Sep 2, 2022

Conversation

taroken6
Copy link
Contributor

@taroken6 taroken6 commented Jun 30, 2022 •
edited by aeschli
Loading

fixes microsoft/vscode#147353
fixes #250

A minor change that removes syntax errors when selectors start with combinators (ex: >, ~, and +).

@aeschli aeschli self-assigned this Sep 1, 2022
@aeschli aeschli requested a review from dbaeumer September 1, 2022 14:46
@aeschli aeschli added this to the September 2022 milestone Sep 1, 2022
@aeschli
Copy link
Contributor

aeschli commented Sep 1, 2022

@taroken6 Thanks a lot, I added some tests.
Can you sign the Contributor License Agreement?

@taroken6
Copy link
Contributor Author

taroken6 commented Sep 1, 2022

@taroken6 Thanks a lot, I added some tests. Can you sign the Contributor License Agreement?

Think I signed it. Didn't see word from CLA Bot.

@aeschli aeschli merged commit f967abc into microsoft:main Sep 2, 2022
@itsmebasti itsmebasti mentioned this pull request Sep 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbaeumer dbaeumer dbaeumer approved these changes

Assignees

@aeschli aeschli

Labels
None yet
Projects
None yet
Milestone
September 2022
3 participants
@taroken6 @aeschli @dbaeumer