Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inlay hints Chinese translate mistakes. #9624

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

kouhe3
Copy link
Contributor

@kouhe3 kouhe3 commented Jul 22, 2022

fix :

  • Improper translation of 'suppress'
  • Should not translate const, auto index , swap

@sean-mcmanus sean-mcmanus added this to the 1.12.0 milestone Jul 22, 2022
@sean-mcmanus sean-mcmanus requested review from Colengms and a team July 22, 2022 18:31
@michelleangela
Copy link
Contributor

michelleangela commented Jul 22, 2022

Do we need to file an internal bug to the loc team for this so they can correct it on their source control? Otherwise, the next time they provide updates to the loc files, this will get reverted.

@sean-mcmanus
Copy link
Contributor

Do we need to file an internal bug to the loc team for this so they can correct it on their source control? Otherwise, the next time they provide updates to the loc files, this will get reverted.

Yes, @Colengms usually handles that.

@Colengms
Copy link
Contributor

Do we need to file an internal bug to the loc team for this so they can correct it on their source control? Otherwise, the next time they provide updates to the loc files, this will get reverted.

Yes, @Colengms usually handles that.

This can go in. I will open bugs for this on my next pass through the loc strings (as I'll find more issues then and open a bug per language).

@sean-mcmanus sean-mcmanus merged commit b42091e into microsoft:main Jul 25, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants