Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inlay hint tests, fix setting update of autoDeclarationTypes.showOnLeft #9622

Merged
merged 2 commits into from
Jul 22, 2022

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Jul 21, 2022

  • Fix setting update of autoDeclarationTypes.showOnLeft.
  • Add inlay hint tests to E2E intelliSense tests. (The E2E intelliSense tests only run once a week internally)

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 22, 2022

@michelleangela Is the test passing or failing? I see the last run failing on Linux:

  1. [Inlay hints test]
    [Inlay Hints - parameter names]:

    AssertionError [ERR_ASSERTION]: Incorrect number of results.

    • expected - actual
      -20
      +16

also, one of my changes caused the Windows E2E binary test to fail so the Windows typescript tests aren't running -- I'm not sure why there's a difference test output with the E2E version versus our primary test pass, i.e. it seems like they should have the same results and I haven't seen what a difference is yet.

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 22, 2022

Also -- why is the root test task showing as a pass when the inlay hint test fails? It's possible a change I made a while ago may have broken the test fail processing.

@sean-mcmanus
Copy link
Contributor

If you want to me to get the Windows E2E test to pass right away you or I could potentially add a fallback baseline for the failing tests until I can figure out what is causing the difference (not sure when that will be yet...hopefully next week).

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Jul 22, 2022

If you want to me to get the Windows E2E test to pass right away you or I could potentially add a fallback baseline for the failing tests until I can figure out what is causing the difference (not sure when that will be yet...hopefully next week).

Oh, I believe the test failure is caused by a difference between the use of git clone and a non-git clone checkout leading to \r\n versus \n differences on Windows -- I think I can just add a fallback to handle both cases.

@michelleangela
Copy link
Contributor Author

@michelleangela Is the test passing or failing? I see the last run failing on Linux:

  1. [Inlay hints test]
    [Inlay Hints - parameter names]:
    AssertionError [ERR_ASSERTION]: Incorrect number of results.

    • expected - actual
      -20
      +16

also, one of my changes caused the Windows E2E binary test to fail so the Windows typescript tests aren't running -- I'm not sure why there's a difference test output with the E2E version versus our primary test pass, i.e. it seems like they should have the same results and I haven't seen what a difference is yet.

The E2E test on Linux should show fail for that one test case not passing. The test case "[Inlay Hints - parameter name]" is supposed to fail until the issue for split parameter is resolved.

@michelleangela michelleangela merged commit c357584 into main Jul 22, 2022
@michelleangela michelleangela deleted the mimatias/inlaytests branch July 22, 2022 22:22
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants