Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix compileCommand updating. #5688

Merged
merged 2 commits into from
Jun 25, 2020
Merged

Fix compileCommand updating. #5688

merged 2 commits into from
Jun 25, 2020

Conversation

sean-mcmanus
Copy link
Contributor

Fix for #5687

@sean-mcmanus sean-mcmanus requested a review from a team June 24, 2020 18:44
@michelleangela
Copy link
Contributor

How does removing the "rename" event check fix the issue?

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Jun 24, 2020 •
edited
Loading

How does removing the "rename" event check fix the issue?

It's only firing rename events (in some cases), which is a known problem with the fs.watch API. The check to exclude rename is unnecessary.

@bpbradley bpbradley mentioned this pull request Jun 24, 2020
Closed
@sean-mcmanus sean-mcmanus merged commit 832165f into master Jun 25, 2020
@sean-mcmanus sean-mcmanus deleted the seanmcm/fixCompileCommandsUpdate branch June 25, 2020 21:33
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michelleangela michelleangela michelleangela approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sean-mcmanus @michelleangela