ignore 'screen size is bogus' error; fixes microsoft/vscode/issues/100563 (and microsoft/vscode/issues/75932) #5669
Conversation
…itiates similar fix for a different extension microsoft/vscode-node-debug/commit/5298920
nukoyluoglu
changed the title
nukoyluoglu
changed the title
| @@ -175,6 +175,10 @@ function execChildProcess(process: string, workingDirectory?: string): Promise<s | |||
| } | |||
|
|
|||
| if (stderr && stderr.length > 0) { | |||
| if (stderr.indexOf('screen size is bogus') >= 0) { | |||
There was a problem hiding this comment.
I don't understand how this fixes it. Should there some code in the "if" statement?
There was a problem hiding this comment.
Or put the "reject" line in an "else".
There was a problem hiding this comment.
putting the reject statement inside the “else” statement was the intention, i believe i must have committed a wrong version. will fix it.
|
Thanks |
|
Your fix should be available with https://github.com/microsoft/vscode-cpptools/releases/tag/0.29.0-insiders . |
I could not find my fix in this version. See: 0.28.3...0.29.0-insiders and https://github.com/microsoft/vscode-cpptools/blob/0.29.0-insiders/Extension/src/Debugger/nativeAttach.ts - where you can see that the fix has not been merged. Also, currently the fix does not allow process picking. Please request changes to move the "return" statement on line 184 inside the else statement above. |
| // see similar fix for the Node - Debug (Legacy) Extension at https://github.com/microsoft/vscode-node-debug/commit/5298920 | ||
| } else { | ||
| reject(new Error(stderr)); | ||
| } | ||
| return; |
There was a problem hiding this comment.
This return statement must be inside the else statement above it.
There was a problem hiding this comment.
Okay, thanks. I'll submit a new PR to master for our next release.
|
@nukoyluoglu Oops. Sorry about that -- I didn't realize the PR was to our release branch and not master. |
…0563 (and microsoft/vscode/issues/75932) (#5669) * ignore 'screen size is bogus' error; fixes microsoft/vscode#75932; imitiates similar fix for a different extension microsoft/vscode-node-debug/commit/5298920
|
This should be available (for real) this time with https://github.com/microsoft/vscode-cpptools/releases/tag/0.29.0-insiders2 |
Corresponding issue: microsoft/vscode#100563
The error below appears when using the Debugger with "type": "cppdbg" and "request": "attach", while picking and attaching to a process through WSL. The root of the error is in the process of fetching remote diagnostics for 'WSL: Ubuntu' since the same error occurs when viewing the Process Explorer, as well. The proposed fix ignores this error silently. The fix imitates a similar commit implemented for the Node - Debug (Legacy) Extension (microsoft/vscode-node-debug@5298920), which also fixes the same issue (microsoft/vscode#75932). The issue was closed, but the fix was only implemented for that particular extension.