Add a maximum search results for goto symbol #12131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbrow
reviewed
Mar 21, 2024
bobbrow
reviewed
Mar 21, 2024
bobbrow
approved these changes
Mar 21, 2024
| @@ -142,6 +142,7 @@ export interface SettingsParams { | |||
| maxConcurrentThreads: number | null | undefined; | |||
| maxCachedProcesses: number | null | undefined; | |||
| maxMemory: number | null | undefined; | |||
| maxSymbolSearchResults: number | null | undefined; | |||
There was a problem hiding this comment.
Is this supposed to be null?
There was a problem hiding this comment.
no. @fearthecowboy, can you fix this one too?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to goto symbol experiment - add a
c_cpp.maxSymbolSearchResultssetting to cap the maximum number of results returned to the userNeeds the native code PR as well.