Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate squiggle from all glob configurations #12072

Merged
merged 20 commits into from
Mar 13, 2024
Merged

Conversation

browntarik
Copy link
Contributor

Addresses: #12070

@Colengms
Copy link
Contributor

Colengms commented Mar 6, 2024

This change prevent the squiggle. Does that mean this scenario actually worked properly for the user, and the only issue was an unexpected squiggle in the JSON file?

@browntarik
Copy link
Contributor Author

This change prevent the squiggle. Does that mean this scenario actually worked properly for the user, and the only issue was an unexpected squiggle in the JSON file?

It just gets rid of the squiggle

@browntarik browntarik changed the title Allow glob to occur during all configuration change scenarios Eliminate squiggle from valid glob configurations Mar 6, 2024
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Mar 6, 2024

This change prevent the squiggle. Does that mean this scenario actually worked properly for the user, and the only issue was an unexpected squiggle in the JSON file?

It just gets rid of the squiggle

@browntarik I don't fully understand still -- is there a bug still with glob not working? Or is the bug just with the squiggle?

UPDATE: I see the glob working, i.e. just a bug with the squiggle.

Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all error squiggles not working now.

@browntarik browntarik changed the title Eliminate squiggle from valid glob configurations Eliminate squiggle from all glob configurations Mar 12, 2024
Copy link
Contributor

@sean-mcmanus sean-mcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paths ending with * or **should still squiggle -- those are not wild card expansions, but determine if a path is recursive or not. And it might be easier to check curPath instead of escapedPath, because escapedPath has the * escaped with \\, i.e. it should only skip * if it's not at the end of the path.

@browntarik browntarik enabled auto-merge (squash) March 13, 2024 17:13
@browntarik browntarik merged commit 3d81801 into main Mar 13, 2024
4 checks passed
@browntarik browntarik deleted the browntarik/fixGlob branch March 13, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants