-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate squiggle from all glob configurations #12072
Conversation
This change prevent the squiggle. Does that mean this scenario actually worked properly for the user, and the only issue was an unexpected squiggle in the JSON file? |
It just gets rid of the squiggle |
@browntarik I don't fully understand still -- is there a bug still with glob not working? Or is the bug just with the squiggle? UPDATE: I see the glob working, i.e. just a bug with the squiggle. |
…ode-cpptools into browntarik/fixGlob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see all error squiggles not working now.
…ode-cpptools into browntarik/fixGlob
…ode-cpptools into browntarik/fixGlob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Paths ending with *
or **
should still squiggle -- those are not wild card expansions, but determine if a path is recursive or not. And it might be easier to check curPath instead of escapedPath, because escapedPath has the *
escaped with \\
, i.e. it should only skip *
if it's not at the end of the path.
Addresses: #12070