Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up the command palette. #11259

Merged
merged 4 commits into from
Jul 28, 2023
Merged

Clean up the command palette. #11259

merged 4 commits into from
Jul 28, 2023

Conversation

sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus commented Jul 28, 2023 •
edited
Loading

Address most of #10421 . The regex usage is based on what the TypeScript extension does (I ran across this while looking into their Extract Function support, so I decided to clean it up now).

@sean-mcmanus sean-mcmanus requested a review from a team July 28, 2023 00:48
@sean-mcmanus
Copy link
Contributor Author

Do we need to file another issue to address anything else or is this good enough for now?

fearthecowboy
fearthecowboy reviewed Jul 28, 2023
View reviewed changes
Copy link
Member

@fearthecowboy fearthecowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regexes are fun!

/^(cuda-cpp|c|cpp)$/ might be a bit more readable but I'm not sure that it makes a differnce

fearthecowboy
fearthecowboy previously approved these changes Jul 28, 2023
View reviewed changes
@sean-mcmanus
Copy link
Contributor Author

Regexes are fun!

/^(cuda-cpp|c|cpp)$/ might be a bit more readable but I'm not sure that it makes a differnce

Sure, that seems better, I'll try that.

@sean-mcmanus
Copy link
Contributor Author

sean-mcmanus commented Jul 28, 2023 •
edited
Loading

I changed it to /^(c|(cuda-)?cpp)$/ to avoid the extra -cpp (well, it's just 1 char shorter).

@sean-mcmanus sean-mcmanus merged commit 6b20994 into main Jul 28, 2023
@sean-mcmanus sean-mcmanus deleted the seanmcm/cleanupCommandPalette branch July 28, 2023 21:45
@aldirenio
Copy link

ola galera boa noite
eu quero instalar o c++ e suas dependencias mais ta osso alquem poria me ajudar

@github-actions github-actions bot locked and limited conversation to collaborators Sep 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michelleangela michelleangela michelleangela approved these changes

@fearthecowboy fearthecowboy fearthecowboy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sean-mcmanus @aldirenio @fearthecowboy @michelleangela