Auto-configure a default custom configuration provider even if default.compilerPath is set
#10607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This logic is intended to auto-configure a detected custom configuration provider if no other configuration information is found. Since we may now write a compiler to the
default.compilerPathsetting, if needed to identify a trustable compiler, it seems like we should disregard when only that is set when determining whether to automatically use a custom configuration provider.Whether this is the correct behavior may be open for debate. For instance, if someone were intentionally using just
default.compilerPathto configure their environment, this may wind up using a custom configuration provider where they don't want it to.