Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some automated check in import_edge_strings.js to check if the loc string count is correct #11349

Open
sean-mcmanus opened this issue Aug 21, 2023 · 0 comments
Open

Add some automated check in import_edge_strings.js to check if the loc string count is correct #11349

sean-mcmanus opened this issue Aug 21, 2023 · 0 comments
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service reliability

Comments

@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 21, 2023 •
edited
Loading

It seems like it might be possible to add a check in import_edge_strings.js to check if the number loc strings in message.json matches the count of English strings that EDG expects in error_msg.txt. That would prevent crashes like #11336 .
@sean-mcmanus sean-mcmanus added Language Service reliability internal Used to opt-out an issue from having GitHub actions applied to it labels Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
internal Used to opt-out an issue from having GitHub actions applied to it Language Service reliability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sean-mcmanus