Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.17.3 regression: IntelliSense crashes when certain error messages occur with any language pack #11336

Closed
warzone-oier opened this issue Aug 17, 2023 · 7 comments · Fixed by #11339
Assignees
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release reliability verified Bug has been reproduced world ready An issue relating string character encodings, localization translations, etc.
Milestone

Comments

@warzone-oier
Copy link

Environment

  • OS and Version: Windows 10
  • VS Code Version: 1.81.1
  • C/C++ Extension Version: v1.17.3
  • If using SSH remote, specify OS of remote machine: no SSH

Bug Summary and Steps to Reproduce

Bug Summary:
IntelliSense has error between brackets like this below:
a
However, it didn't occur in v1.16.3:

b

Configuration and Logs

{
    "configurations": [
        {
            "name": "Win32",
            "includePath": [
                "${workspaceFolder}/**"
            ],
            "defines": [
                "_DEBUG",
                "UNICODE",
                "_UNICODE"
            ],
            "windowsSdkVersion": "10.0.19041.0",
            "compilerPath": "D:/Microsoft Visual Studio/2019/Community/VC/Tools/MSVC/14.29.30133/bin/Hostx64/x64/cl.exe",
            "intelliSenseMode": "windows-msvc-x64"
        }
    ],
    "version": 4
}

Other Extensions

No response

Additional context

No response

@michelleangela
Copy link
Contributor

@wangr-x
I'm not able to reproduce the auto-complete behavior you're seeing in 1.17.3. Could you provide the following logs? Could you also check if other IntelliSense features are working, such as "Find All References"?

@michelleangela michelleangela added Language Service more info needed The issue report is not actionable in its current state labels Aug 17, 2023
@michelleangela michelleangela self-assigned this Aug 17, 2023
@warzone-oier
Copy link
Author

warzone-oier commented Aug 18, 2023

@michelleangela
The log said IntelliSense process crashed ,
and I have found that the problem only occurs if the Chinese (Simplified) (简体中文) Language Pack is installed,

@sean-mcmanus sean-mcmanus removed the more info needed The issue report is not actionable in its current state label Aug 18, 2023
@sean-mcmanus sean-mcmanus added bug reliability regression A bug that didn't exist in a previous release labels Aug 18, 2023
@sean-mcmanus sean-mcmanus added this to the 1.17.4 milestone Aug 18, 2023
@sean-mcmanus sean-mcmanus added verified Bug has been reproduced world ready An issue relating string character encodings, localization translations, etc. labels Aug 18, 2023
@sean-mcmanus sean-mcmanus changed the title IntelliSense problem in v1.17.3 1.17.3: IntelliSense may crash with certain language packs Aug 18, 2023
@sean-mcmanus sean-mcmanus pinned this issue Aug 18, 2023
@sean-mcmanus sean-mcmanus changed the title 1.17.3: IntelliSense may crash with certain language packs 1.17.3: IntelliSense crashes when certain error messages occur with any language pack Aug 19, 2023
@sean-mcmanus
Copy link
Contributor

sean-mcmanus commented Aug 19, 2023

@wangr-x Thanks for reporting this -- we have a fix at #11339 for 1.17.4 on Monday (PST, so the update may not be seen till Tuesday for some time zones). In the meanwhile, you can work around it downgrading to 1.16.3, disabling the language pack, or updating the file in your extension install corresponding to <pathTo>/.vscode/extensions/ms-vscode.cpptools-1.17.3-<osInfo>/bin/messages/zh-cn/messages.json with the contents at https://raw.githubusercontent.com/microsoft/vscode-cpptools/0ee2cd89f5e3de9a163f02a8713bbb7a7915c488/Extension/bin/messages/zh-cn/messages.json.

The issue should repro with any language pack, not just Chinese (Simplified).

We'll improve our internal update processes to prevent this type of issue in the future.

@sean-mcmanus sean-mcmanus changed the title 1.17.3: IntelliSense crashes when certain error messages occur with any language pack 1.17.3 regression: IntelliSense crashes when certain error messages occur with any language pack Aug 19, 2023
@sean-mcmanus
Copy link
Contributor

@sean-mcmanus sean-mcmanus unpinned this issue Aug 21, 2023
@LiRWZ
Copy link

LiRWZ commented Aug 22, 2023

version1.17.3 has been torturing me for two days。

@bobbrow
Copy link
Member

bobbrow commented Aug 22, 2023

@LiRWZ this should be fixed in 1.17.4. Can you give that version a try?

@sean-mcmanus
Copy link
Contributor

@bobbrow My impression was that @LiRWZ saw the previous "Fixed with" comment and was just expressing their feelings in regards to the past 2 days before the fix was released.

@bobbrow bobbrow added the fixed Check the Milestone for the release in which the fix is or will be available. label Oct 4, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug fixed Check the Milestone for the release in which the fix is or will be available. Language Service regression A bug that didn't exist in a previous release reliability verified Bug has been reproduced world ready An issue relating string character encodings, localization translations, etc.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants