Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deleted documents are highlighted #2467

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bk201-
Copy link
Contributor

@bk201- bk201- commented Nov 25, 2024

Fixes #2437

  • Deleted documents highlighted by line-through decoration
  • No actions with deleted rows

image
image
image
image

- Deleted documents highlighted by line-through decoration
- No actions with deleted rows
- Deleted documents highlighted by line-through decoration
- No actions with deleted rows
@bk201- bk201- requested review from a team as code owners November 25, 2024 10:04
@tnaum-ms
Copy link
Collaborator

It’s an interesting approach! However, I anticipate that once it’s available, there will be feature requests for an ‘undo’ operation.

@bk201-
Copy link
Contributor Author

bk201- commented Nov 25, 2024

Well, then we will say that result is just Query Representation what we can't change as well as undo any actions.

Why can't we remove these records from the table? Because the have statistics and metrics which linked to certain results in the table. My opinion, it is obvious that any actions with records will be represented only after re-running query.

@tnaum-ms
Copy link
Collaborator

tnaum-ms commented Dec 3, 2024

Well, then we will say that result is just Query Representation what we can't change as well as undo any actions.

Why can't we remove these records from the table? Because the have statistics and metrics which linked to certain results in the table. My opinion, it is obvious that any actions with records will be represented only after re-running query.

I'd leave it for you, @bk201-, and @sevoku to decide, as it's in your domain. I wouldn't prefer to go down that UX path. If the correlation between the result set and the stats is a concern, I suggest replacing the metrics with a message stating that it's not available as the result set has changed.

Copy link
Member

@sevoku sevoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion on this, I'd say let's go with this approach and see what feedback we get? We could also use a grey-ish text or background color.

@tnaum-ms don't we have support for deletion in Mongo? How do you handle it? We should shoot for the same experience, especially in such cases.

@bk201-
Copy link
Contributor Author

bk201- commented Dec 4, 2024

I suggest replacing the metrics with a message stating that it's not available as the result set has changed.

@sevoku @tnaum-ms In this case any deletion will fail all metrics at all, not only for this page for every page. I'm not competent at this question, I would ask someone who uses both tabs. Questions like

  • How often the metrics are required?
  • How is important these data?

@tnaum-ms
Copy link
Collaborator

tnaum-ms commented Dec 4, 2024

I don't have a strong opinion on this, I'd say let's go with this approach and see what feedback we get? We could also use a grey-ish text or background color.

@tnaum-ms don't we have support for deletion in Mongo? How do you handle it? We should shoot for the same experience, especially in such cases.

I simply remove it from the database and from the view. It's gone once a user confirms they want to delete. Deleted data being visible suggests an undo option that we don't and likely won't have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants