Support temp folders not located on system drive #974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes CMake: Scan for Kits
The following changes are proposed:
The purpose of this change
If you do not change back to "%~dp0" after calling "devbat" and your temp directory is on another drive as your Visual Studio installation the corresponding ".env" file will not be created next to "devbat" but in the user's home directory. This causes the Visual Studio 2017 Kits to not be found.
Occured with:
Other Notes/Information
I hope the information provided by me is sufficient. This is my first pull request here :)
Edit: I did some more investigation. Seems like the proposed fix is a workaround for issues like
https://developercommunity.visualstudio.com/content/problem/26780/vsdevcmdbat-changes-the-current-working-directory.html
https://developercommunity.visualstudio.com/content/problem/134471/vcvarsallbat-changes-current-directory.html