Consistently normalize absolute and relative paths #963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Uhm, is there something wrong with this PR? |
|
@GeorchW, I'm sorry, we haven't had a chance to review it yet. December is a month where most MS employees take vacation, and we're spread pretty thin right now. My developer assigned to this project also had to take some emergency time off this month so things are running more slowly than expected. I apologize for that. We will take a look as soon as we can. |
bobbrow
approved these changes
Jan 22, 2020
|
Thank you for your contribution. Again, I'm sorry it has taken so long to commit it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize even absolute paths, not just relative ones. Otherwise, absolute paths containing '.' and '..' may not be normalized out,
The personal itch I was tackling was that, when compiling with
zapcc, the diagnostics had paths containing '..' . This made VSCode open a separate editor when clicking on the diagnostic, displaying the same file using a different path, while not displaying the squiggles in the original editor.