-
Notifications
You must be signed in to change notification settings - Fork 464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix miDebuggerPath problem with fallback behavior #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactoring extracts the logic to generate debugconfigurations from the debug command into a new module. This new module generates debugConfigurations out of the cmakecache and support now the generation of miDebuggerPath. This module is reintegrated into the debug command.
Apple use always the llvm backend to compile, this makes it necessary to call lldb instead of gdb for gcc.
…hTarget to reuse setters and getters. The debugger had always target name and path as independent information. This information are part of the ExecutableTarget. This refactoring use in the launch and call step of the debugger the ExecutableTarget. - Replace separate target name and path parameter by ExecutableTarget - Add debugger integration tests - Refactor set and get launchTarget
The needed debugger dependes in some cases from the used compiler. This modification adds a section for the debugger into the kit file. This allows to switch gdb dependent on the used gcc or clang compiler.
Can #420 be closed? |
The testing fails on windows, it needs the extension cpptools for the cppvdbg debug launch. |
Hmm... what about separating the generation of the |
vector-of-bool
approved these changes
Jun 5, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses item #375 and #242
Same as #420.
Additional it has a test debugger command mechanism and a fallback to gdb in search path.
Fallback behavior
Removed debugger integration into kit file.