Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CppTools-API v5 integration #1789

Merged
merged 3 commits into from
Apr 21, 2021
Merged

CppTools-API v5 integration #1789

merged 3 commits into from
Apr 21, 2021

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Apr 20, 2021

This change addresses item #1624

This changes IntelliSenseMode and Standard values as optional (undefined) for CppTools-API v5+

The following changes are proposed:

  • Return undefined IntelliSenseMode for CppTools-API v5+
  • If Standard C or C++ cannot be parsed, returns undefined for CppTools-API v5+

The purpose of this change

CppTools-API v5 integration

@michelleangela michelleangela linked an issue Apr 20, 2021 that may be closed by this pull request
@michelleangela michelleangela self-assigned this Apr 20, 2021
@michelleangela michelleangela requested a review from Colengms April 20, 2021 20:13
@bobbrow bobbrow added this to the 1.7.1 milestone Apr 20, 2021
@bobbrow
Copy link
Member

bobbrow commented Apr 20, 2021

private _cpptoolsVersion: cpt.Version = cpt.Version.latest;

I'm not sure why this didn't work previously because it looks like this should have already been v5 when someone upgraded the package.json a month ago.


Refers to: src/cpptools.ts:391 in 79de84a. [](commit_id = 79de84a, deletion_comment = False)

@bobbrow
Copy link
Member

bobbrow commented Apr 20, 2021

I figured it out. You also need to update extension.ts line 661. We're requesting v4 and we need to request v5 specifically.

@bobbrow bobbrow requested a review from a team April 20, 2021 23:57
@bobbrow bobbrow merged commit 7d90712 into develop Apr 21, 2021
@bobbrow bobbrow deleted the mimatias/v5 branch April 21, 2021 15:52
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use version 5 of cpptools-api
2 participants