Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing of target architecture flags with values that include arm64 #1751

Merged
merged 3 commits into from
Apr 8, 2021

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Apr 8, 2021

This change addresses item #1735

  • The value arm64 used for target architecture flags would get parsed as arm which resulted in sending the incorrect IntelliSenseMode to the vscode-cpptools extension.
  • If gcc compiler is used, it would return clang compiler for IntelliSenseMode instead of gcc.

This changes

  • Code that parses value of target architecture flags. If value includes arm64, then it will return arm64 architecture instead of arm to use as the architecture variant of the IntelliSenseMode.
  • Code that returns IntelliSenseMode based on compiler path input will return gcc-<arch> IntelliSenseMode if gcc compiler is used.

The purpose of this change

To return the correct compiler-architecture variant for IntelliSenseMode to vscode-cpptools extension.

Other Notes/Information

@michelleangela michelleangela requested a review from Colengms April 8, 2021 22:17
@michelleangela michelleangela self-assigned this Apr 8, 2021
@michelleangela michelleangela added this to the 1.7.0 milestone Apr 8, 2021
@michelleangela michelleangela merged commit 0c51cfd into develop Apr 8, 2021
@michelleangela michelleangela deleted the dev/mimatias/ism-fix branch April 15, 2021 06:40
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants