Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

${workspaceFolder} is not working for "environmentSetupScript" option… #1406

Merged
merged 5 commits into from
Oct 8, 2020

Conversation

alan-wr
Copy link
Contributor

@alan-wr alan-wr commented Aug 10, 2020

… in project cmake-kits.json file #1309

Signed-off-by: alan-wr [email protected]

This change addresses item #1309

This changes [[visible behavior/performance/documentation/etc.]]

The following changes are proposed:

The purpose of this change

Other Notes/Information

@bobbrow
Copy link
Member

bobbrow commented Aug 10, 2020

Thanks for your PR @alan-wr! We're finishing up another project this week and then hopefully we'll be back to CMake Tools and look at your PR.

@bobbrow bobbrow added this to the 1.5.0 milestone Aug 10, 2020
@alan-wr
Copy link
Contributor Author

alan-wr commented Aug 10, 2020

Thanks.

src/kit.ts Outdated Show resolved Hide resolved
src/kit.ts Outdated Show resolved Hide resolved
src/extension.ts Show resolved Hide resolved
@andreeis andreeis merged commit 0810f2e into microsoft:develop Oct 8, 2020
@bobbrow bobbrow modified the milestones: 1.6.0, 1.5.0 Oct 15, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants