Fix multiple silent kit scans in a multi-root workspace #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the silent kits scanning is called at the end of opening a folder, a multi-root project will trigger unnecessarily more than one kits scanning.
The fix in this PR is to check if there is already a scan in progress but that was not enough because for a multi root project, the multiple scans are first triggered but the boolean gets set later and we still have more than one scanning processes, depending on various timings.
In addition to check for scans in progress, the call to silent scan is made only for the first folder.
Another alternative would be to move the silent scan earlier in the extension activation (or outside the scope of a folder) since this operation has nothing to do with a folder specifically. I remembered the issues with the first approach and thought that checking first folder only is not that bad.
#1302