Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ARM IntelliSenseModes and GNU language standards for cpptools #1209

Merged
merged 9 commits into from
May 5, 2020

Conversation

michelleangela
Copy link
Contributor

@michelleangela michelleangela commented Apr 30, 2020

This change addresses items #1155, #1208

This changes

  • Setting IntelliSenseMode in vscode-cpptools based on compiler name and target architecture parsed from compiler flags.

  • Parsing C and C++ language standard compiler flag options to support GNU language standard options in vscode-cpptools.

  • Added unit tests for both new features.

The purpose of this change

Support ARM IntelliSenseModes in vscode-cpptools extension #1155

Support GNU language standard options in vscode-cpptools extension #1208

@michelleangela michelleangela requested a review from andreeis April 30, 2020 20:04
src/cpptools.ts Outdated Show resolved Hide resolved
@michelleangela michelleangela requested a review from bobbrow May 2, 2020 00:01
Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. This looks good.

src/cpptools.ts Show resolved Hide resolved
test/unit-tests/cpptools.test.ts Outdated Show resolved Hide resolved
src/cpptools.ts Outdated Show resolved Hide resolved
@michelleangela michelleangela merged commit 01dbf10 into develop May 5, 2020
@michelleangela michelleangela deleted the mimatias/arm-mode branch May 5, 2020 22:00
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants