Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan silently if there are no available kits #1192

Merged

Conversation

xisui-MSFT
Copy link
Collaborator

In the offline discussion, there was two decisions around this experience:

  1. If opening a CMake project and there’s an toolchain file entry in settings.json, then don’t do anything related to Kits.
  2. If opening a CMake project and there is NO toolchain file entry in settings.json and if there is no kits.json, then silently start scanning for kits.

We finally decided not to implement (1) because a kit is a super set of a toolchain file, and although it's possible to detect multiple settings in settings.json instead of only the toolchain file entry, this is unnecessarily complicated.

@bobbrow
Copy link
Member

bobbrow commented Apr 22, 2020

This should also address #708

@andreeis andreeis merged commit 2693aec into microsoft:develop Apr 23, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jan 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants