Skip to content
This repository has been archived by the owner on Dec 6, 2022. It is now read-only.

Add more variables tests for other scopes #855

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

digeff
Copy link
Contributor

@digeff digeff commented Jun 6, 2019

Add more variables tests for other scopes
We test the same basic set of variable types in each of the possible scopes

Variables scopes
    √ local
    √ globals
    √ script
    √ block
    √ catch
    √ closure
    √ eval
    √ with
    √ module

@EricCornelson
Copy link
Contributor

Looks good. The only question I have is whether the order of the variables can ever change, (or if it did change, is that a bug or not).

@digeff
Copy link
Contributor Author

digeff commented Jun 10, 2019

The order at least in some occasions matter. The this variable should always appear as the first variable for example...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants