This repository has been archived by the owner on Dec 6, 2022. It is now read-only.
Fix several bugs to make the tests run deterministically #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roblourens
reviewed
May 31, 2019
| } | ||
|
|
||
| public get url(): URI { | ||
| const address = this._server.address(); |
There was a problem hiding this comment.
It looks like the server object is just passed around so you can get the address, how about just returning the address? Do you want tests messing with the server in other ways?
There was a problem hiding this comment.
We need to return one of the servers to be able to call .close() on the cleanUp.
At the moment the _server variable is private, so the tests can't mess with it (yet)...
roblourens
reviewed
May 31, 2019
digeff
force-pushed
the
async_server
branch
5 times, most recently
from
751caf2 to
e7523d3
Compare
|
Note: There are still some race conditions that haven't been solved by this PR. I think the current builds are passing with a 50% chance or so. Given that this PR seems to be making things better, I'm inclined to merge it as-is. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSFT_TEST_TIMEOUT_MULTIPLIER: Modify the multiplier to have the tests timeout faster in your Dev Machine (Useful when the tests are failing).
test/int/adapter.test.ts: Updated the tests to generate a DA log
test/int/fixtures/launchProject.ts: Updated to create web server before the debug-adapter, and to return the web-server url
test/int/fixtures/launchWebServer.ts: Updated to wait for the async methods of the server, to launch on a random launchProject, and return the url as a property and inside the launch configuration
test/int/framework/frameworkTestSupport.ts: The port is randomly choosen by the web-server, so we removed the url from the test spec
test/int/puppeteer/launchPuppeteer.ts: Use a random port for the debug adapter. Disconnect the debug-adapter, and close puppeteer and chrome on cleanUp
test/int/puppeteer/puppeteerSuite.ts: Add the launch project to the context so the tests can access the web-server url
test/int/stackTrace.test.ts & test/int/wizards/breakpoints/implementation/stackTraceObjectAssertions.ts: Because the url is not fixed any more, it's more difficult to feed it to the StackTraceValidator, so pass a full url instead of a relative one instead
test/int/testSetup.ts: Kill chrome.exe before the tests, it's more reliable