Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Check if 'Debugger.setAsyncCallStackDepth' method unimplemented #227

Closed

Conversation

itoys
Copy link

@itoys itoys commented Aug 9, 2017

Fix for #226

@msftclas
Copy link

msftclas commented Aug 9, 2017

@itoys,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@roblourens
Copy link
Member

This won't fix it, the problem is that the runtime doesn't implement it. You need to call the method and ignore the error if it returns failure.

@itoys
Copy link
Author

itoys commented Aug 9, 2017

I already fixed it in my code. Just ignore that error. But I thought it's correct to check if method implemented.

@roblourens
Copy link
Member

That check doesn't tell you if it's implemented, that object is just a proxy calling the target with whatever you give it.

@itoys
Copy link
Author

itoys commented Aug 10, 2017

Oh, I see. It won't work(

@roblourens roblourens closed this Aug 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants