Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Support source mapping of stack traces in the Debug Console #6

Closed
roblourens opened this issue May 5, 2016 · 21 comments
Closed

Support source mapping of stack traces in the Debug Console #6

roblourens opened this issue May 5, 2016 · 21 comments

Comments

@roblourens
Copy link
Member

From @auchenberg on March 22, 2016 22:11

When an error is thrown with a stack trace, we should support source mapping of the source:

Actual:
app js - timey in 2016-03-22 15-09-38

Click on Scope.$scope.onAddNewClick (http://localhost:8080/app_bundled.js:234:5) triggers:
app js - timey in 2016-03-22 15-10-13

Expected:
Path to files within stack traces are source mapped to the original source.

Copied from original issue: Microsoft/vscode-chrome-debug#132

@roblourens roblourens changed the title Support source mapping of stack traces Support source mapping of stack traces in the Debug Console Aug 27, 2016
@nojvek
Copy link
Contributor

nojvek commented Feb 21, 2017

@roblourens Seems like this issue has been open for a while. I can take a stab at it if you're busy with other tasks. Let me know.

@auchenberg
Copy link
Contributor

@nojvek Please hack away, if time allows it :)

@roblourens
Copy link
Member Author

That would be cool. I don't have any immediate plan to work on this.

roblourens added a commit that referenced this issue Mar 23, 2017
Support source mapping of stack traces in the Debug Console #6
@auchenberg
Copy link
Contributor

Landed in #190

@nojvek
Copy link
Contributor

nojvek commented Mar 25, 2017 via email

@auchenberg
Copy link
Contributor

auchenberg commented Mar 25, 2017 via email

@roblourens
Copy link
Member Author

I update it whenever I have time to test, and write a changelog and stuff. Planning on doing it by today or tomorrow.

Probably will stay a separate extension for the time being.

@nojvek
Copy link
Contributor

nojvek commented Mar 25, 2017 via email

@roblourens
Copy link
Member Author

Yep, also I just updated the chrome extension :)

@nojvek
Copy link
Contributor

nojvek commented Mar 25, 2017 via email

@aramando
Copy link

aramando commented Apr 6, 2017

Any ideas why this still isn't working for me? I am running the latest versions of Code and the Chrome Debug extension, and my webRoot launch config property is set right. Do you have to have sourcemap files for the JS files in question, even if they wouldn't ordinarily need one?

@roblourens
Copy link
Member Author

I just (like an hour ago) updated it to map from URL to local file, if you aren't using sourcemaps. If you are using sourcemaps, then it should work if setting BPs and debugging with sourcemaps works.

@aramando
Copy link

aramando commented Apr 6, 2017

Oh, fantastic! So I just need to wait for that to make it into the next release of the extension? Any idea roughly what kind of timeframe that might occur in?

@roblourens
Copy link
Member Author

The release went out today, it's in 2.7.3 if you don't already have that

@aramando
Copy link

aramando commented Apr 6, 2017

Oh, I am already running that, but it's still not working :-/

@roblourens
Copy link
Member Author

Can you open another issue with details?

@AskYous
Copy link

AskYous commented Jun 13, 2017

Hey @roblourens, I am also receiving an error saying it cannot find the file. I am running Debugger for Chrome version 3.1.2. I posted a screenshot below. Notice a couple of things:

  1. My website is running on localhost:1337. For some reason, VSCode is trying to open the file in /1337/js/components.js. (How did the port get into the source path???)
  2. I have source mapping on for my typescript files.
  3. The file open is the launch.json file shown in the screenshot. I pointed the webRoot folder to my assets folder, yet it seems to completely ignore it.

image

@roblourens
Copy link
Member Author

That's strange, but a different problem, can you open a new issue?

Can you also set "trace": true in your launch config, repro this again, and include the log?

@AskYous
Copy link

AskYous commented Jun 13, 2017

@roblourens Sure, I'm on it. I got here through a google search. Question: where does the debug info log into when I turn trace on in Windows 10? I don't know where it is.

@roblourens
Copy link
Member Author

roblourens commented Jun 13, 2017

Thanks - it writes a log file and prints the path at the top of the console.

@AskYous
Copy link

AskYous commented Jun 13, 2017

Ok. I opened #212.

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants