Implement ExceptionInfoRequest - Fix #191

src/chrome/chromeDebugAdapter.ts

@@ -8,7 +8,7 @@ import {InitializedEvent, TerminatedEvent, Handles, ContinuedEvent, BreakpointEv
 import {ICommonRequestArgs, ILaunchRequestArgs, ISetBreakpointsArgs, ISetBreakpointsResponseBody, IStackTraceResponseBody,
     IAttachRequestArgs, IScopesResponseBody, IVariablesResponseBody,
     ISourceResponseBody, IThreadsResponseBody, IEvaluateResponseBody, ISetVariableResponseBody, IDebugAdapter,
-    ICompletionsResponseBody, IToggleSkipFileStatusArgs, IInternalStackTraceResponseBody, ILoadedScript, IAllLoadedScriptsResponseBody} from '../debugAdapterInterfaces';
+    ICompletionsResponseBody, IToggleSkipFileStatusArgs, IInternalStackTraceResponseBody, ILoadedScript, IAllLoadedScriptsResponseBody, IExceptionInfoResponseBody} from '../debugAdapterInterfaces';
 import {IChromeDebugAdapterOpts, ChromeDebugSession} from './chromeDebugSession';
 import {ChromeConnection} from './chromeConnection';
 import * as ChromeUtils from './chromeUtils';
@@ -183,7 +183,8 @@ export abstract class ChromeDebugAdapter implements IDebugAdapter {
             supportsConditionalBreakpoints: true,
             supportsCompletionsRequest: true,
             supportsHitConditionalBreakpoints: true,
-            supportsRestartFrame: true
+            supportsRestartFrame: true,
+            supportsExceptionInfoRequest: true
         };
     }
 
@@ -414,6 +415,27 @@ export abstract class ChromeDebugAdapter implements IDebugAdapter {
         }).catch(err => logger.error('Problem while smart stepping: ' + (err && err.stack) ? err.stack : err));
     }
 
+    public exceptionInfo(args: DebugProtocol.ExceptionInfoArguments): IExceptionInfoResponseBody {
+        if (args.threadId !== ChromeDebugAdapter.THREAD_ID) {
+            throw errors.invalidThread(args.threadId);
+        }
+
+        if (this._exception) {
+            const response: IExceptionInfoResponseBody = {
+                exceptionId: this._exception.className,
+                description: utils.firstLine(this._exception.description),
+                breakMode: 'unhandled',
+                details: {
+                    stackTrace: this._exception.description
+                }
+            };
+
+            return response;
+        } else {
+            throw errors.noStoredException();
+        }
+    }
+
     private async shouldSmartStep(frame: Crdp.Debugger.CallFrame): Promise<boolean> {
         if (!this.smartStepEnabled()) return Promise.resolve(false);
 
@@ -761,9 +783,10 @@ export abstract class ChromeDebugAdapter implements IDebugAdapter {
             const lineNum = parseInt(matches[3], 10);
             const columnNum = parseInt(matches[4], 10);
             const clientPath = this._pathTransformer.getClientPathFromTargetPath(path);
-            const mapped = await this._sourceMapTransformer.mapToAuthored(clientPath || path, lineNum, columnNum);
+            const mapped = await this._sourceMapTransformer.mapToAuthored(clientPath || path, lineNum - 1, columnNum);
 
-            if (mapped && mapped.source && mapped.line && mapped.column) {
+            if (mapped && mapped.source && utils.isNumber(mapped.line) && utils.isNumber(mapped.column)) {
+                this._lineColTransformer.mappedExceptionStack(mapped);
                 exceptionLines[i] = exceptionLines[i].replace(
                     `${path}:${lineNum}:${columnNum}`,
                     `${mapped.source}:${mapped.line}:${mapped.column}`

src/debugAdapterInterfaces.d.ts

@@ -119,6 +119,17 @@ export interface IAllLoadedScriptsResponseBody {
     loadedScripts: ILoadedScript[];
 }
 
+export interface IExceptionInfoResponseBody {
+    /** ID of the exception that was thrown. */
+    exceptionId: string;
+    /** Descriptive text for the exception provided by the debug adapter. */
+    description?: string;
+    /** Mode that caused the exception notification to be raised. */
+    breakMode: DebugProtocol.ExceptionBreakMode;
+    /** Detailed information about the exception. */
+    details?: DebugProtocol.ExceptionDetails;
+}
+
 declare type PromiseOrNot<T> = T | Promise<T>;
 
 /**

src/errors.ts

@@ -104,3 +104,28 @@ export function noCallStackAvailable(): DebugProtocol.Message {
         format: localize('VSND2023', "No call stack available.")
     };
 }
+
+export function invalidThread(threadId: number): DebugProtocol.Message {
+    return {
+        id: 2030,
+        format: 'Invalid thread {_thread}',
+        variables: { _thread: threadId + '' },
+        sendTelemetry: true
+    };
+}
+
+export function exceptionInfoRequestError(): DebugProtocol.Message {
+    return {
+        id: 2031,
+        format: 'exceptionInfoRequest error',
+        sendTelemetry: true
+    };
+}
+
+export function noStoredException(): DebugProtocol.Message {
+    return {
+        id: 2032,
+        format: 'exceptionInfoRequest error: no stored exception',
+        sendTelemetry: true
+    };
+}

src/transformers/lineNumberTransformer.ts

@@ -36,6 +36,10 @@ export class LineColTransformer implements IDebugTransformer  {
         scopeResponse.scopes.forEach(scope => this.mapScopeLocations(scope));
     }
 
+    public mappedExceptionStack(location: { line: number; column: number }): void {
+        this.convertDebuggerLocationToClient(location);
+    }
+
     private mapScopeLocations(scope: DebugProtocol.Scope): void {
         this.convertDebuggerLocationToClient(scope);
 

src/utils.ts

@@ -515,4 +515,8 @@ export function getLine(msg: string, n = 0): string {
 
 export function firstLine(msg: string): string {
     return getLine(msg);
+}
+
+export function isNumber(num: number): boolean {
+    return typeof num === 'number';
 }