Fix #282 by ignoring %c specifiers

microsoft · Nov 9, 2016 · bce3d60 · bce3d60
1 parent 47a37df
commit bce3d60
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/chrome/consoleHelper.ts b/src/chrome/consoleHelper.ts
@@ -72,11 +72,14 @@ function resolveParams(m: Crdp.Runtime.ConsoleAPICalledEvent): string {
             formatted = Math.floor(+param.value);
         } else if (formatSpecifiers[i] === 'f') {
             formatted = +param.value;
-        } else if (['o', 'O', 'c'].indexOf(formatSpecifiers[i]) >= 0) {
+        } else if (formatSpecifiers[i] === 'c') {
+            // %c - Applies CSS color rules
+            // Could use terminal color codes in the future
+            formatted = '';
+        } else if (['o', 'O'].indexOf(formatSpecifiers[i]) >= 0) {
             // Not supported -
             // %o - expandable DOM element
             // %O - expandable JS object
-            // %c - Applies CSS color rules
             formatted = param.value;
         }
 

diff --git a/test/chrome/consoleHelper.test.ts b/test/chrome/consoleHelper.test.ts
@@ -47,6 +47,10 @@ suite('ConsoleHelper', () => {
             doAssert(Runtime.makeLog('test', null, undefined), 'test null undefined');
         });
 
+        test('strips %c patterns', () => {
+            doAssert(Runtime.makeLog('foo %cbar', 'color: red'), 'foo bar');
+        });
+
         test('network error - need Log domain');
 
         test('objects- waiting on Microsoft/vscode-node-debug#4');