Fix microsoft/vscode#25594 - respect stackTrace range arguments

microsoft · May 24, 2017 · 63554b9 · 63554b9
1 parent 7e6fae3
commit 63554b9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/src/chrome/chromeDebugAdapter.ts b/src/chrome/chromeDebugAdapter.ts
@@ -1218,15 +1218,21 @@ export abstract class ChromeDebugAdapter implements IDebugAdapter {
 
         // Only process at the requested number of frames, if 'levels' is specified
         let stack = this._currentPauseNotification.callFrames;
-        if (args.levels) {
+        const totalFrames = stack.length;
+        if (typeof args.startFrame === 'number') {
+            stack = stack.slice(args.startFrame);
+        }
+
+        if (typeof args.levels === 'number') {
             stack = stack.filter((_, i) => i < args.levels);
         }
 
         const stackFrames = stack.map(frame => this.callFrameToStackFrame(frame))
             .concat(this.asyncFrames(this._currentPauseNotification.asyncStackTrace));
 
         const stackTraceResponse: IInternalStackTraceResponseBody = {
-            stackFrames
+            stackFrames,
+            totalFrames
         };
         this._pathTransformer.stackTraceResponse(stackTraceResponse);
         this._sourceMapTransformer.stackTraceResponse(stackTraceResponse);

diff --git a/src/debugAdapterInterfaces.d.ts b/src/debugAdapterInterfaces.d.ts
@@ -87,6 +87,7 @@ export interface IThreadsResponseBody {
 
 export interface IStackTraceResponseBody {
     stackFrames: DebugProtocol.StackFrame[];
+    totalFrames?: number;
 }
 
 export interface IInternalStackFrame extends DebugProtocol.StackFrame {