Use node 16 in pipelines

[alexweininger]

Just testing out the macOS pipeline with node 16.

Not meant to be merged.

Note: even if this doesn't fix the macOS pipeline, it's probably a good idea to use Node 16 in the pipelines since that's what version of Node VS Code uses (and we use).

[bwateratmsft]

Docker uses Node v16 and it's still been failing like crazy, so I doubt that will fix it. At this point I'm inclined to believe @philliphoff that it's just that I'm not believing in the Mac pipeline enough.

[philliphoff]

@alexweininger / @bwateratmsft I wonder if you could try using macOS-12 as the host, just for kicks, as macOS-latest actually means MacOS 11 Big Sur, which is, confusingly, not the latest.

[nturinski]

Was this just a fluke, or did upgrading to macOS-12 actually fix this?

[alexweininger]

Was this just a fluke, or did upgrading to macOS-12 actually fix this?

Since we check directories for changes before running certain checks, the failing checks weren't run for this PR (hence the durations are really short). Should I merge this so we can find out if it really works? Can't make it worse...

[philliphoff]

@alexweininger Should we try moving to @vscode/test-electron, which seems to have a fix for a similar issue: vscode-test#153.

[bwateratmsft]

Good spot @philliphoff, we should try that.

[bwateratmsft]

Docker was already on @vscode/test-electron but I bumped it up to v2.1.5, and I'm 5 for 5 on build runs. So, I'm inclined to believe this works.