-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ui package into utils and azureutils packages #1054
Conversation
I plan on waiting for #1050 to be merged so I can pick up those changes. |
It's not related but after this PR is finished is probably a good time to fix #978. |
a0bea49
to
bf58858
Compare
bf58858
to
188d8b2
Compare
utils/package.json
Outdated
"vscode-tas-client": "^0.1.22" | ||
}, | ||
"devDependencies": { | ||
"@azure/core-client": "^1.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know these are only being used as dev dependencies, but shouldn't these still go into the azure
package?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, I moved those and the uiUtils that needed these types to the azure package. So now the only azure related (dev) dependency in the utils package is @azure/ms-rest-azure-env
which we need for ISubscriptionContext
.
Working towards #1051
Work timeline
AzureNameStep
→AzExtNameStep
Changes
ui/src/index.ts
shows a nice summary of what's been relocated (seeui/index.d.ts
for more detailed summary).The following has moved from ui to new azure utils package:
The following have been exported from ui and imported by azure utils package:
And I added
registerAzureUtilsExtensionVariables
which is a carbon copy ofregisterAppServiceExtensionVariables
.Migrating
I've migrated and tested locally Docker and VMs to use both of the new packages. See what those changes look like:
Notes
I plan for the new
@microsoft/vscode-azext-utils
package to live inutils
. However, I've left the changes in theui
folder so you can see diff on GitHub. Once approved I'll revert the changes made in theui
folder. That way we're left with an unchanged version of thevscode-azureextensionui
package code in case we need to make fixes/changes in there later.