Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retryPolicy on creating services (blob/queue/fileshare/table) #380

Merged
merged 1 commit into from
Jun 28, 2019
Merged

Add retryPolicy on creating services (blob/queue/fileshare/table) #380

merged 1 commit into from
Jun 28, 2019

Conversation

PrashanthCorp
Copy link
Contributor

@PrashanthCorp PrashanthCorp commented Jun 27, 2019 •
edited
Loading

The timeout errors arise due to the lack of retries in blobService.

Repro:

 npx create react-app my-react-app
 cd my-react-app
 npm install

Deploy the entire app, then deploy it again and choose yes to delete all files

Fixes #352
Fixes #345
Fixes #370
Fixes #334
Fixes #340
Fixes #338
Fixes #339
Fixes #342
Fixes #317
Fixes #362

Add retryPolicy on creating services
ab132aa 
(blob/queue/fileshare/table)
@PrashanthCorp PrashanthCorp requested a review from a team as a code owner June 27, 2019 23:47
@StephenWeatherford
Copy link
Contributor

We should consider a hotfix after people test with private bits.

@StephenWeatherford
Copy link
Contributor

You have to have "fixes" in front of each bug. You can see this by hovering over the "fixes" link above.

@PrashanthCorp PrashanthCorp merged commit 18e82ed into master Jun 28, 2019
@ejizba ejizba mentioned this pull request Nov 20, 2019
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Feb 10, 2021
@alexweininger alexweininger deleted the ps/timeouts branch August 10, 2022 21:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@StephenWeatherford StephenWeatherford StephenWeatherford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@PrashanthCorp @StephenWeatherford