Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to scope select subscriptions prompt by tenant #934

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

alexweininger
Copy link
Member

This adds the ability to scope the select subscriptions prompt by tenant. It also adds the option to filter by account, but that's not implemented in this PR.

If a prompt is scoped to a tenant, it won't change any selected subscriptions that aren't in that tenant. Only subscriptions shown in the picker will be removed or added to the selected subscriptions setting.

@alexweininger alexweininger requested a review from a team as a code owner October 3, 2024 18:18
bwateratmsft
bwateratmsft previously approved these changes Oct 3, 2024
motm32
motm32 previously approved these changes Oct 3, 2024
@alexweininger
Copy link
Member Author

A further improvement to the select subscription picker would be to group the picks by tenant/account

@alexweininger
Copy link
Member Author

A further improvement to the select subscription picker would be to group the picks by tenant/account

Foiled by this
image

@alexweininger alexweininger dismissed stale reviews from motm32 and bwateratmsft via a2e4c43 October 3, 2024 20:48
bwateratmsft
bwateratmsft previously approved these changes Oct 3, 2024
@nturinski
Copy link
Member

This error is being thrown by us. I think there's no actual limitation with VS Code's quick picker that prevents us from doing it. As far as I know, the grouping is just us sorting everything by group and using the QuickPickItemKind.Separator in between each group.

@alexweininger
Copy link
Member Author

This error is being thrown by us. I think there's no actual limitation with VS Code's quick picker that prevents us from doing it. As far as I know, the grouping is just us sorting everything by group and using the QuickPickItemKind.Separator in between each group.

Yeah I was tempted to @ you fix it

@alexweininger alexweininger merged commit d526677 into main Oct 3, 2024
3 checks passed
@alexweininger alexweininger deleted the alex/select-subscriptions-changes branch October 3, 2024 22:08
@microsoft microsoft locked and limited conversation to collaborators Nov 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants