Add Service Connector #3790
Add Service Connector #3790
Conversation
package.json
Outdated
| }, | ||
| { | ||
| "command": "azureFunctions.createServiceConnector", | ||
| "when": "view == azureResourceGroups && viewItem =~ /serviceConnectorGroupItem/", | ||
| "group": "4@1" | ||
| }, | ||
| { | ||
| "command": "azureFunctions.deleteServiceConnector", | ||
| "when": "view == azureResourceGroups && viewItem =~ /serviceConnectorItem/", | ||
| "group": "4@2" | ||
| }, | ||
| { | ||
| "command": "azureFunctions.validateServiceConnector", | ||
| "when": "view == azureResourceGroups && viewItem =~ /serviceConnectorItem/", | ||
| "group": "4@3" |
There was a problem hiding this comment.
These need to be available in the focus view also
package.nls.json
Outdated
| @@ -101,6 +103,7 @@ | |||
| "azureFunctions.toggleAppSettingVisibility": "Toggle App Setting Visibility.", | |||
| "azureFunctions.uninstallFuncCoreTools": "Uninstall Azure Functions Core Tools", | |||
| "azureFunctions.validateFuncCoreTools": "Validate the Azure Functions Core Tools is installed before debugging.", | |||
| "azureFunctions.validateServiceConnector": "Validate Service Connector", | |||
There was a problem hiding this comment.
Is this the right wording? Should it be "Validate connection" or "Validate"?
There was a problem hiding this comment.
Yeah, I'm not sure what it says on the Portal, but I feel like Validate connection makes more sense.
There was a problem hiding this comment.
Right now the portal just says Validate. I could also say Validate connection status since that is also shown in the portal
| const activityContext = { | ||
| ...context, | ||
| ...await createActivityContext(), | ||
| activityTitle: localize('validateServiceConnector', 'Validate Service Connector'), |
There was a problem hiding this comment.
Depending on what you do with Alex's comment above, make sure that you keep it consistent here.
| @@ -22,7 +22,7 @@ export async function validateServiceConnector(context: IActionContext, item?: S | |||
| const activityContext = { | |||
| ...context, | |||
| ...await createActivityContext(), | |||
| activityTitle: localize('validateServiceConnector', 'Validate Service Connector'), | |||
There was a problem hiding this comment.
I think we want this title to be more detailed. Is it possible to add in the name of what we're validating here?
There was a problem hiding this comment.
Like add in the name of the specific service connector?
There was a problem hiding this comment.
Yeah, I feel that the activity title should have more detail so it's easy to know what is being validated.
There was a problem hiding this comment.
I think at the very least it can be changed back to "Validate Service Connector"
There was a problem hiding this comment.
I think adding the name of the specific service connector makes the most sense!
There was a problem hiding this comment.
When I do it from the command palette it says Validate undefined
There was a problem hiding this comment.
I think I'd be OK just hiding this from the command palette.
Hmm how did you do this? I validated the same connection twice from both the tree and command palette and they both succeeded. |
Happens when I expand both activities and reveal the children |
Yeah I noticed this happening to me in Container Apps as well. My workaround has been to incorporate random UUIDs to keep the contexts original. |
| @@ -101,6 +103,7 @@ | |||
| "azureFunctions.toggleAppSettingVisibility": "Toggle App Setting Visibility.", | |||
| "azureFunctions.uninstallFuncCoreTools": "Uninstall Azure Functions Core Tools", | |||
| "azureFunctions.validateFuncCoreTools": "Validate the Azure Functions Core Tools is installed before debugging.", | |||
| "azureFunctions.validateServiceConnector": "Validate", | |||
There was a problem hiding this comment.
Make sure to make the same changes you did on the App Service PR here
This reverts commit 58588c1.
Service connector is now available on the portal for function apps.
Related to microsoft/vscode-azuretools#1419
Here is how it looks in the tree view:
