Refactor remote debugging commands into common library #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrcrane
force-pushed
the
refactor-remotedebug
branch
from
7ef6775 to
58b2e83
Compare
|
ping @nturinski @mrcrane what's the status of this PR? |
|
Omg both of you 😂😂😂
|
|
Sorry I got pulled away to work on other things and left this hanging. Clearly restarting the build isn't enough to get this passing 😄 I'll fix it up and send an update soon. |
mrcrane
force-pushed
the
refactor-remotedebug
branch
from
58b2e83 to
d088f47
Compare
mrcrane
force-pushed
the
refactor-remotedebug
branch
from
d088f47 to
359872f
Compare
|
I rebased onto master and everything builds and tests properly. I did some manual testing as a sanity check and it looks good. All it actually needed was for the package.json to reference a newer 'vscode-azureappservice' that contains the new changes from microsoft/vscode-azuretools#522 @nturinski Feel free to take a look now. I updated the description to have a little more context. Definitely let me know if the context menu looks good or if I should reorder anything. |
nturinski
approved these changes
Aug 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull out the common remote debugging code into the vscode-azureappservice library.
This change requires the changes in microsoft/vscode-azuretools#522 (see that PR for more details about what is being changed here)
Also has some changes to get rid of the "Stop Remote Debugging" command and clean up the context menu grouping remote debugging and SSH commands: