Fix deadlocks involving processes where JTF is _not_ present #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s` test This repros the deadlock hypothesized in microsoft#983
Mutable statics are more or less likely to cause problems with testing or advanced product scenarios. In this case though, it seems *very* likely that every shipping scenario will be drastically simpler by defaulting to sharing state across instances, so that is the default. Advanced cases can opt into isolating those instances however, and I have a test to verify this. Fixes microsoft#983
BertanAygun
approved these changes
Jan 11, 2024
RyanToth3
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug description is found in #983.
The fix is simply to share the
JoinableTask"token" acrossJsonRpcinstances. We correlateJoinableTasktokens acrossJsonRpcinstances (by default).Mutable statics are more or less likely to cause problems with testing or advanced product scenarios. In this case though, it seems very likely that every shipping scenario will be drastically simpler by defaulting to sharing state across instances, so that is the default. Advanced cases can opt into isolating those instances however, and I have a test to verify this.
Fixes #983