Add JoinableTaskFactory integration #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AArnott
commented
Mar 1, 2023
3 tasks
AArnott
commented
Mar 1, 2023
AArnott
commented
Mar 1, 2023
This avoids deadlocks that RPC would otherwise introduce by carrying a `JoinableTask` token across RPC so that when/if the RPC call ever makes it back to the original AppDomain (or never leaves it) such that the callee needs the main thread, it will be able to reach it if the caller owns the main thread.
BertanAygun
reviewed
Mar 1, 2023
| this.joinableTaskTokenWithoutJtf.Value = parentToken; | ||
| } | ||
|
|
||
| if (this.JoinableTaskFactory is null || parentToken is null) |
There was a problem hiding this comment.
If there is a JTF instance but no token was provided in the header, should we still use JTF to dispatch for the benefit of the current process? (although I am not sure what benefit there would be)
There was a problem hiding this comment.
Lifeng and I couldn't think of any benefit in doing so. But there is a non-zero overhead from doing so. Thus, we only do it when we feel it's justified by skipping when there is no parent token.
BertanAygun
approved these changes
Mar 1, 2023
AArnott
added a commit
to AArnott/vs-streamjsonrpc
that referenced
this pull request
Mar 6, 2023
microsoft#886 introduced JsonRpc-JoinableTaskFactory integration, but did not document it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids deadlocks that RPC would otherwise introduce by carrying a
JoinableTasktoken across RPC so that when/if the RPC call ever makes it back to the original AppDomain (or never leaves it) such that the callee needs the main thread, it will be able to reach it if the caller owns the main thread.