Fix ArrayTypeMismatchException on Android #879
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.NET arrays are covariant, so a
string[]
can masquerade as anobject[]
. But apparentlyobject[].AsSpan
will fail on such a masquerading array, presumably because aSpan<object>
would allow an object to be written with no further type checking. ButReadOnlySpan<object>
is safe over astring[]
, presumably because it is read only so the type incompatibility is of no concern.In mono, our
ParameterInfo[]
array is actually an array of a derived type, so it throws. By creating aReadOnlySpan<ParameterInfo>
instead of aSpan<ParameterInfo>
, we avoid the exception.Fixes #860