Include RPC server stack trace in RemoteInvocationException.ToString() #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaBStevens
approved these changes
Dec 4, 2019
milopezc
approved these changes
Dec 4, 2019
AArnott
force-pushed
the
fix369
branch
2 times, most recently
from
75fea4e to
3d77261
Compare
AArnott
commented
Dec 4, 2019
There was a problem hiding this comment.
These two lines could be written as "if (this.DeserializedErrorData is CommonErrorData errorData)", couldn't they?
Yes, they can. I tried that syntax before and it didn't work at the time because I had a loop where errorData had to be typed as CommonErrorData?, but in my latest code it does work, so I've written.
It isn't always possible to do, but when the server provides a `CommonErrorData` object, we certainly can do it. I endeavored to copy the string format that .NET uses for its own exception formatting, including for inner exceptions. Closes microsoft#369
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
- Coverage 90.94% 90.36% -0.59%
==========================================
Files 47 47
Lines 3557 3581 +24
==========================================
+ Hits 3235 3236 +1
- Misses 322 345 +23
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It isn't always possible to do, but when the server provides a
CommonErrorDataobject, we certainly can do it.I endeavored to copy the string format that .NET uses for its own exception formatting, including for inner exceptions.
Closes #369