Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of internal types used in return types of internal proxy interfaces #345

Merged
merged 1 commit into from
Sep 25, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Sep 25, 2019

No description provided.

@codecov-io
Copy link

codecov-io commented Sep 25, 2019

Codecov Report

Merging #345 into master will increase coverage by 0.14%.
The diff coverage is 82.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #345      +/-   ##
==========================================
+ Coverage   87.67%   87.82%   +0.14%     
==========================================
  Files          35       35              
  Lines        2394     2407      +13     
  Branches      460      463       +3     
==========================================
+ Hits         2099     2114      +15     
+ Misses        218      214       -4     
- Partials       77       79       +2
Impacted Files Coverage Δ
src/StreamJsonRpc/ProxyGeneration.cs 98.66% <100%> (+0.64%) ⬆️
src/StreamJsonRpc/SkipClrVisibilityChecks.cs 86.36% <77.41%> (+1.85%) ⬆️
src/StreamJsonRpc/MessageHandlerBase.cs 97.67% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e530f35...5d2e54c. Read the comment docs.

@AArnott AArnott requested a review from jepetty September 25, 2019 15:47
@AArnott AArnott added this to the v2.2 milestone Sep 25, 2019
@AArnott AArnott self-assigned this Sep 25, 2019
@AArnott AArnott merged commit 7c6f148 into microsoft:master Sep 25, 2019
@AArnott AArnott deleted the internalIfaceRetType branch September 25, 2019 18:03
AArnott pushed a commit that referenced this pull request Feb 5, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
AArnott added a commit that referenced this pull request Feb 5, 2025
* Update becheran/mlc action to v0.19.1

* Suppress an expected doc warning

* Remove dependabot.yml

* Update becheran/mlc action to v0.19.2 (#345)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

* Stick with .NET 8 packages

* Update microbuild to 2.0.181

* Update dependency ubuntu to v24

* Avoid daily updates of VS packages

* Group VS SDK package updates

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants