Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of events declared on the base types of target objects #341

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Sep 18, 2019

Tips for reviewers:

  • I changed the existing tests to use a derived type, which caused several to fail.
  • I wrapped the existing event enumerating code to do so within an enumeration of the type hierarchy, using exactly the same technique we already used to find methods all the way up the hierarchy. All tests passed after that.

Fixes #340

@AArnott AArnott added this to the v2.2 milestone Sep 18, 2019
@AArnott AArnott self-assigned this Sep 18, 2019
@codecov-io
Copy link

codecov-io commented Sep 18, 2019

Codecov Report

Merging #341 into master will decrease coverage by 0.29%.
The diff coverage is 62.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #341     +/-   ##
=========================================
- Coverage   87.93%   87.63%   -0.3%     
=========================================
  Files          34       34             
  Lines        2296     2281     -15     
  Branches      445      441      -4     
=========================================
- Hits         2019     1999     -20     
+ Misses        215      214      -1     
- Partials       62       68      +6
Impacted Files Coverage Δ
src/StreamJsonRpc/JsonRpc.cs 91.3% <62.5%> (-0.75%) ⬇️
src/StreamJsonRpc/Exceptions/RemoteRpcException.cs 33.33% <0%> (-33.34%) ⬇️
...treamJsonRpc/Exceptions/ConnectionLostException.cs 50% <0%> (-25%) ⬇️
src/StreamJsonRpc/ProxyGeneration.cs 97.6% <0%> (-0.35%) ⬇️
src/StreamJsonRpc/WebSocketMessageHandler.cs 100% <0%> (+11.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94d097...588143d. Read the comment docs.

@AArnott AArnott merged commit 3d3bdd5 into microsoft:master Sep 19, 2019
@AArnott AArnott deleted the dev/andarno/fix340 branch September 19, 2019 09:18
AArnott pushed a commit that referenced this pull request Jan 25, 2025
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Events are not wired through the target object if they are on a base type
3 participants