Added ETW events #322
Added ETW events #322
Conversation
Codecov Report
@@ Coverage Diff @@
## v2.1 #322 +/- ##
==========================================
- Coverage 89.64% 87.43% -2.21%
==========================================
Files 31 32 +1
Lines 1951 2046 +95
Branches 369 390 +21
==========================================
+ Hits 1749 1789 +40
- Misses 156 209 +53
- Partials 46 48 +2
Continue to review full report at Codecov.
|
src/StreamJsonRpc/JsonRpc.cs
Outdated
|
|
||
| if (JsonRpcEventSource.Instance.IsEnabled()) | ||
| { | ||
| JsonRpcEventSource.Instance.SendRequestStop($"ResponseDetails: {responseDetails}; RequestDetails: Id: \"{request.Id}\", Method: \"{request.Method}\", Arguments: \"{JsonRpcEventSource.GetArgumentsString(request.Arguments)}\""); |
There was a problem hiding this comment.
For some reason, Duration_Msec is not getting captured for most of the SendRequestStop events. For such events, no ActivityId shows up in PerfView.
In case of WinForms designer, we spawn a .NetCore process from devenv. Not sure if framework mismatch is the issue.
There was a problem hiding this comment.
That's probably because of missing attribute properties. See #322 (comment)
There was a problem hiding this comment.
Tried but it didn't help.
|
/azp run vs-streamjsonrpc |
|
Commenter does not have sufficient privileges for PR 322 in repo microsoft/vs-streamjsonrpc |
AArnott
force-pushed
the
dev/shgu/etwEvents
branch
from
47a39ad to
959bdc7
Compare
|
I took the liberty of squashing and rebasing your commits from master to v2.1 so that we can check this in for 16.3. |
|
I've revised the ETW events somewhat to provide more data-friendly events. Here's how the perfview grid looks now. Note the columns dedicated for methods, args. We provide this string data only on the start event so the stop event can be leaner.
|
AArnott
force-pushed
the
dev/shgu/etwEvents
branch
from
0a6751b to
bd10c27
Compare
By providing method names and args as separate parameters instead of a pre-formatted string, ETW recognizes it as distinct data, allowing us to filter and sort on it, etc.
AArnott
force-pushed
the
dev/shgu/etwEvents
branch
from
bd10c27 to
a0ba0d7
Compare
|
Thanks Andrew for making the changes. Looks very good now. |
Update .NET SDK and xunit.runner.visualstudio
A sample PerfView log:
Call stacks getting captured with the events: