Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move distill rules from reader to writer. #78

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

richardstanton
Copy link
Member

@richardstanton richardstanton commented Nov 19, 2024

Running DistillProjectConfigurations on each .SLN load was causing perf regressions in scenarios where this is not needed. Since this is only needed to simplify the model when saving to .SLNX, the call was moved from the sln reader to the slnx writer.

  • A test was updated where the rule added to the slnx was removed by this change, the rule was updated to one that wouldn't be optimized out.

@richardstanton richardstanton merged commit aa1b8e3 into main Nov 19, 2024
1 check passed
@richardstanton richardstanton deleted the users/richsta/distilonsave branch November 19, 2024 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants