[nanodbc] add support for install --head #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ras0219-msft
reviewed
Nov 2, 2018
ports/nanodbc/portfile.cmake
Outdated
| ) | ||
|
|
||
| vcpkg_install_cmake() | ||
|
|
||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/debug/include) | ||
| file(REMOVE_RECURSE ${CURRENT_PACKAGES_DIR}/cmake ${CURRENT_PACKAGES_DIR}/debug/cmake) |
There was a problem hiding this comment.
Could this be
if(EXISTS ${CURRENT_PACKAGES_DIR}/cmake)
vcpkg_fixup_cmake_targets(CONFIG_PATH cmake)
endif()?
There was a problem hiding this comment.
Oh, yes! This is very nice!
Not documented yet?
|
LGTM, though I'll wait for your response about |
|
@ras0219-msft working. |
|
I'll look forward to 2.13. Thanks for the PR! |
dantti
pushed a commit
to dantti/vcpkg
that referenced
this pull request
Nov 9, 2018
* [nanodbc] add support for use of --head * single line copyright handler * support cmake targets for v2.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #4607 an update for nanodbc is requested.
This commit adds support for installing from HEAD with
vcpkg install nanodbc --head.With the upcoming release (v2.13) a few changes are introduced:
Vcpkg only builds dynamic libraries for the current release.
A single change when building the current release (v2.12.4):
vcpkg_check_linkage(ONLY_DYNAMIC_LIBRARY)prevents building a dynamic library against the static CRT. (Unless explicitly configured in a triplet.)The previous portfile only displayed a status message.