Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cpprestsdk] Update to v2.10.8 and add brotli feature. #4617

Merged
merged 1 commit into from
Dec 1, 2018
Merged

[cpprestsdk] Update to v2.10.8 and add brotli feature. #4617

merged 1 commit into from
Dec 1, 2018

Conversation

BillyONeal
Copy link
Member

The brotli feature is on by default for Windows only. We think it'll probably work on other platforms but haven't tested that extensively.

@ras0219-msft
Copy link
Contributor

ras0219-msft commented Nov 4, 2018 •
edited
Loading

Thanks for the PR!

I'm seeing regressions on x64-uwp and arm-uwp with this change, can you take a look?

Processing arm-uwp
    azure-storage-cpp                                           Skip vs Fail
    bitserializer                                               Skip vs Pass
    cpprestsdk                    **regression**                Fail vs Pass
    signalrclient                                               Skip vs Fail
Processing arm64-windows
    cpprestsdk                                                  Skip vs Skip
Processing x64-linux
    cpprestsdk                                                  Pass vs Pass
Processing x64-osx
    cpprestsdk                                                  Pass vs Pass
Processing x64-uwp
    azure-storage-cpp                                           Skip vs Fail
    bitserializer                                               Skip vs Pass
    cpprestsdk                    **regression**                Fail vs Pass
    signalrclient                                               Skip vs Fail
Processing x64-windows
    cpprestsdk                                                  Pass vs Pass
Processing x64-windows-static
    cpprestsdk                                                  Pass vs Pass
Processing x86-windows
    cpprestsdk                                                  Pass vs Pass

@BillyONeal BillyONeal mentioned this pull request Nov 7, 2018
Merged
@BillyONeal
[cpprestsdk] Update to v2.10.8 and add brotli feature.
6044ecc 
The brotli feature is on by default for Windows only. We think it'll probably work on other platforms but haven't tested that extensively.
@BillyONeal BillyONeal changed the title [cpprestsdk] Update to v2.10.7 and add brotli feature. [cpprestsdk] Update to v2.10.8 and add brotli feature. Nov 14, 2018
@ras0219-msft ras0219-msft merged commit 8dd8bc1 into microsoft:master Dec 1, 2018
@BillyONeal BillyONeal deleted the update_casablanca branch December 3, 2018 03:55
epistor
epistor reviewed Dec 12, 2018
View reviewed changes
ports/cpprestsdk/CONTROL
@@ -1,10 +1,18 @@
Source: cpprestsdk
Version: 2.10.6-3
Version: 2.10.7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how much this matters, but I think you meant 2.10.8 here...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes, looks like that didn't get updated. Oh well, will get resolved next update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epistor epistor epistor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BillyONeal @ras0219-msft @epistor