Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsonifier, discordcoreapi] Attempt to fix build hangs and warnings. #42355

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[jsonifier, discordcoreapi] Attempt to fix build hangs and warnings. #42355

wants to merge 2 commits into from
+30 −5

Conversation

BillyONeal
Copy link
Member

@BillyONeal BillyONeal commented Nov 25, 2024 •
edited
Loading

2 potential causes:

  • At least in my testing, build requires >9GB per thread of memory, which might have been 'hanging' by causing the OOM killer to kill the agent.
  • There are 'sub' CMake builds which write to the source tree and stomp on each other.

Related: RealTimeChris/Jsonifier#35
Related: #40229

@BillyONeal
[jsonifier, discordcoreapi] Attempt to fix build hangs and warnings.
d80f573 
2 potential causes:
* At least in my testing, build requires >9GB per core of memory, which might have been 'hanging' by causing the OOM killer to kill the agent.
* There are 'sub' CMake builds which write to the source tree and stomp on each other.

Related: RealTimeChris/Jsonifier#35
@BillyONeal BillyONeal added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 25, 2024
@BillyONeal
Copy link
Member Author

I'm hoping this also fixes the build being very very slow on osx:

image

since this is forcing those machines into heavy swap use.

@BillyONeal
Copy link
Member Author

/cc @RealTimeChris

@JonLiu1993 JonLiu1993 self-assigned this Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BillyONeal @JonLiu1993