-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kerbal] update to v2024.11.1 #42307
Conversation
@jimwang118 should I squash the second commit into the first one? |
You need to run the command: |
Co-authored-by: jim wang <[email protected]>
5d74ca3
to
ed70318
Compare
done |
ports/kerbal/vcpkg.json
Outdated
"description": "Kerbal C++ Template Library", | ||
"homepage": "https://github.com/WentsingNee/Kerbal", | ||
"license": "LGPL-3.0", | ||
"license": "LGPL-3.0-or-later", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain where the -or-later
is documented? The LICENSE does not say that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, this change is suggested by @jimwang118 during his review. Actually, I didn't change my project's LICENSE these days.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't focus and track the policy published by the vcpkg official so I also don't understand. Whether you have updated the policy related to the LICENSE in pursuit of the compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no separate LGPL-3.0 license in the website SPDX-license-list where we are verifying the license, so it is changed to LGPL-3.0-or-later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Either it is LGPL-3.0-or-later
or it is LGPL-3.0-only
. If we do not know exactly, the deprecated fuzzy LGPL-3.0
might be the best fit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WentsingNee Ah, I'm sorry, I didn't notice that you are upstream! In that case, I agree with @dg0yt that the deprecated fuzzy one should remain. I would suggest that, as the upstream maintainer, you clarify in your own project's documentation which you mean, and we'll update the license expression when we ingest that update. However, we don't need that to happen to take this update. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted the license field edit and set auto merge, I assumed @WentsingNee is happy with that given that their initial PR did not contain that change.
./vcpkg x-add-version --all
and committing the result.