Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flux] Update to version 0.4.0 #42027

Merged
merged 3 commits into from
Nov 11, 2024
Merged

[flux] Update to version 0.4.0 #42027

merged 3 commits into from
Nov 11, 2024

Conversation

SidneyCogdill
Copy link
Contributor

@SidneyCogdill SidneyCogdill commented Nov 7, 2024 •
edited by LilyWangLL
Loading

tcbrindle/flux#206
Fixes #42055

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

dg0yt
dg0yt reviewed Nov 7, 2024
View reviewed changes
ports/flux/vcpkg.json Outdated Show resolved Hide resolved
@WangWeiLin-MV WangWeiLin-MV self-assigned this Nov 8, 2024
@WangWeiLin-MV WangWeiLin-MV added the category:port-update The issue is with a library, which is requesting update new revision label Nov 8, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title Update flux to version 0.4.0 [flux] Update to version 0.4.0 Nov 8, 2024
WangWeiLin-MV
WangWeiLin-MV previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The port usage tests pass with the following triplets:

  • x64-windows

@WangWeiLin-MV
Copy link
Contributor

  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.

Please check the issue.

@SidneyCogdill
Copy link
Contributor Author

SidneyCogdill commented Nov 8, 2024 •
edited
Loading

Removing builtin-baseline with the web editor without re-running vcpkg x-add-version locally causes problems and triggers CI. The updated hash is now committed.

@WangWeiLin-MV WangWeiLin-MV added the info:reviewed Pull Request changes follow basic guidelines label Nov 8, 2024
@dg0yt dg0yt mentioned this pull request Nov 8, 2024
Closed
@vicroms vicroms merged commit 6840264 into microsoft:master Nov 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV approved these changes

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[flux] update to v0.4.0
4 participants
@SidneyCogdill @WangWeiLin-MV @dg0yt @vicroms