Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[casadi] first step (no dependencies) #41649

Merged
merged 14 commits into from
Oct 23, 2024
Merged

[casadi] first step (no dependencies) #41649

merged 14 commits into from
Oct 23, 2024

Conversation

jgillis
Copy link
Contributor

@jgillis jgillis commented Oct 18, 2024

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@jgillis
Copy link
Contributor Author

jgillis commented Oct 18, 2024

@microsoft-github-policy-service agree company="yacoda"

dg0yt
dg0yt reviewed Oct 19, 2024
View reviewed changes
Copy link
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be more practical to format the portfile with spaces, not tabs. (Tabs are subject to settings. GH PR review looks strange.)

I see a lot of find modules. I would expect a similar set of dependencies in the manifest.

ports/casadi/portfile.cmake Show resolved Hide resolved
ports/casadi/portfile.cmake Outdated Show resolved Hide resolved
ports/casadi/usage Outdated Show resolved Hide resolved
@dg0yt
Copy link
Contributor

dg0yt commented Oct 19, 2024

Maybe put the PR in draft state as long as it is not ready for review.

@jgillis jgillis marked this pull request as draft October 19, 2024 16:44
@jgillis
Copy link
Contributor Author

jgillis commented Oct 19, 2024 •
edited
Loading

@dg0yt Thanks for your review, I assumed you would not start a review while CI still runs..

CasADi works with a plugin system.
The core is basically dependency-free.
In this first version, I'm packaging the 'core' feature set.
Next up would be coin-or-ipopt dependency, but that's for another PR.
Because of the plugin system, static libraries do not currently make sense.

I'll think about adding the namespace upstream.

@jgillis jgillis marked this pull request as ready for review October 19, 2024 20:49
@jgillis
Copy link
Contributor Author

jgillis commented Oct 19, 2024

@dg0yt The CI checking seems to stall; x64_linux is compiling whole of llvm, and windows builds queue until timeout.
Is this a normal state of affairs or am I just unlucky?

@dg0yt
Copy link
Contributor

dg0yt commented Oct 19, 2024

CI has a real problem.
llvm:x64-linux is building because the PR touches ci.baseline.

@jgillis
Copy link
Contributor Author

jgillis commented Oct 19, 2024

Oh I see, thanks for helping out this vcpkg noob.

@jgillis jgillis marked this pull request as draft October 20, 2024 11:57
@jgillis jgillis marked this pull request as ready for review October 20, 2024 19:54
jimwang118
jimwang118 reviewed Oct 21, 2024
View reviewed changes
ports/casadi/portfile.cmake Outdated Show resolved Hide resolved
ports/casadi/usage Outdated Show resolved Hide resolved
@jimwang118 jimwang118 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Oct 21, 2024
@jimwang118
Copy link
Contributor

Usage test pass with following triplet:

x64-windows

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2024
@data-queue data-queue merged commit d5cf6a9 into microsoft:master Oct 23, 2024
16 checks passed
BillyONeal added a commit to BillyONeal/vcpkg that referenced this pull request Nov 19, 2024
@BillyONeal
Deindex several ports that were =skip.
a38a889 
Removes several ports from the registry that conflict with others and/or are effectively untested in vcpkg's build lab.

[cppmicroservices] This port was added 5 years ago, appears relatively unused, only exists in repology due to vcpkg, and is full of vendored dependencies. It's also broken for most official triplets. Replaces microsoft#34552
[ijg-libjpeg, mozjpeg] Leaf ports that we can't test and conflict with libjpeg-turbo, the curated registry's canonical jpeg implementation.
[optional-bare] Conflicted with optional-lite.
[qt5-canvas3d] Removed by qt5 upstream.
[range-v3-vs2015] No longer maintained by upstream, no longer necessary in 2024.
[rbdl-orb] File conflicts with its own dependency.
[sciter] Left support by upstream 2 years ago and has conflicts with other ports.
[signalrclient] "Obsolete" and conflicts with microsoft-signalr
[spdk-*] Several conflicts with other ports.
[c-dbg-macro] Conflicts with [dbg-macro]
[casadi] microsoft#41649 appears to have been merged in error, casadi/casadi#3896 needs to land before this can be in the curated registry. Moreover, problems in the portfile were skipped in ci.baseline.txt rather than a supports expression. We are happy to bring this port back as soon as that issue is fixed :)
[chromium-base] Not tested anywhere for years.
[libmesh] Conflicts with other ports.
[libpng-apng] Doesn't even exist in the first place.
[libqcow] Release distribution file contains configured sources, while the source code in the repository does not.
[libvmdk] Upstream is gone.
[mecab] Upstream has not been edited in 10 years, combination of =skip and supports clause means not tested.
[shogun] Not tested.

Not deindexed:
[bde] Conflicts with other ports. Warning was given more than a year ago: microsoft#32645 .
However, microsoft#41335 appears to indicate that it works now, so the =skips were removed.
[stxxl] Appears to work on my machine?
[chartdir] Unstable download URLs are now mitigated by asset caching.
[buck-yeh-bux] Looks like these are intended to be in the supports clause.
[boringssl, fluidlite, libressl, libmariadb, libmysql] Appears to have a dedicated userbase despite being untestable in CI.
[libxaw] Needed supports expression for ONLY_DYNAMIC_LIBRARY, should have always been a fail not a skip.

Related: microsoft#42165
@BillyONeal BillyONeal mentioned this pull request Nov 19, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@data-queue data-queue data-queue approved these changes

@jimwang118 jimwang118 jimwang118 approved these changes

Assignees

@jimwang118 jimwang118

Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jgillis @dg0yt @jimwang118 @data-queue