Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zlmediakit] Fix zlmediakit android #39403

Merged
merged 4 commits into from
Jun 27, 2024
Merged

[zlmediakit] Fix zlmediakit android #39403

merged 4 commits into from
Jun 27, 2024

Conversation

foobra
Copy link
Contributor

@foobra foobra commented Jun 20, 2024 •
edited
Loading

  • Changes comply with the maintainer guide.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.~~
  • Only one version is added to each modified port's versions file.

@microsoft-github-policy-service agree

@JonLiu1993 JonLiu1993 changed the title Fix zlmediakit android [zlmediakit] Fix zlmediakit android Jun 20, 2024
@JonLiu1993 JonLiu1993 added the category:port-bug The issue is with a library, which is something the port should already support label Jun 20, 2024
@BillyONeal
Copy link
Member

This change seems reasonable but I'm not sure how to verify that it is correct. Is log supposed to come from the NDK or something else?

Has this fix been submitted upstream?

@BillyONeal BillyONeal marked this pull request as draft June 22, 2024 00:16
@foobra
Copy link
Contributor Author

foobra commented Jun 22, 2024

This change seems reasonable but I'm not sure how to verify that it is correct. Is log supposed to come from the NDK or something else?

Has this fix been submitted upstream?

@BillyONeal When compile Android triplet, one logger file use __android_log_print function which belongs to Android NDK log library , but the origin repo forget to link it.

@foobra foobra marked this pull request as ready for review June 22, 2024 08:40
@BillyONeal
Copy link
Member

@BillyONeal When compile Android triplet, one logger file use __android_log_print function which belongs to Android NDK log library , but the origin repo forget to link it.

Thanks! Seems consistent with https://stackoverflow.com/questions/4455941/

BillyONeal
BillyONeal approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit this upstream?

@foobra
Copy link
Contributor Author

foobra commented Jun 27, 2024

Can you submit this upstream?

Already submit to upstream

BillyONeal
BillyONeal approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Submitted upstream as ZLMediaKit/ZLMediaKit#3670

@BillyONeal BillyONeal merged commit ef7c629 into microsoft:master Jun 27, 2024
17 checks passed
@BillyONeal
Copy link
Member

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@JonLiu1993 JonLiu1993 JonLiu1993 approved these changes

Assignees

@JonLiu1993 JonLiu1993

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@foobra @BillyONeal @JonLiu1993