Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gz-cmake3] Update to 3.4.0 #34010

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Sep 25, 2023

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@talregev
Copy link
Contributor Author

@traversaro @dg0yt
This update is breaking gz-fuel-tools8 port.
It now search for jsoncpp.pc:

-- Fixing pkgconfig file: /mnt/vcpkg-ci/packages/gz-fuel-tools8_x64-linux/lib/pkgconfig/gz-fuel_tools8.pc
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:141 (message):
  /bin/pkg-config --exists gz-fuel_tools8 failed with error code: 1

      ENV{PKG_CONFIG_PATH}: "/mnt/vcpkg-ci/packages/gz-fuel-tools8_x64-linux/lib/pkgconfig:/mnt/vcpkg-ci/packages/gz-fuel-tools8_x64-linux/share/pkgconfig:/mnt/vcpkg-ci/installed/x64-linux/lib/pkgconfig:/mnt/vcpkg-ci/installed/x64-linux/share/pkgconfig"
      output: Package jsoncpp was not found in the pkg-config search path.

  Perhaps you should add the directory containing `jsoncpp.pc'

  to the PKG_CONFIG_PATH environment variable

  Package 'jsoncpp', required by 'gz-fuel_tools8', not found
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:206 (z_vcpkg_fixup_pkgconfig_check_files)
  /mnt/vcpkg-ci/installed/x64-linux/share/ignition-modularscripts/vcpkg-port-config.cmake:56 (vcpkg_fixup_pkgconfig)
  /mnt/vcpkg-ci/installed/x64-linux/share/ignition-modularscripts/vcpkg-port-config.cmake:164 (ignition_modular_build_library)
  ports/gz-fuel-tools8/portfile.cmake:3 (ignition_modular_library)
  scripts/ports.cmake:147 (include)

@talregev talregev marked this pull request as draft September 25, 2023 19:34
@traversaro
Copy link
Contributor

traversaro commented Sep 25, 2023

This update is breaking gz-fuel-tools8 port.
It now search for jsoncpp.pc:

Interesting, probably this was hided by the bug fixed in gazebosim/gz-cmake#374 . Anyhow, it seems that gz-cmake blindly assumes that jsoncpp installs a .pc file in https://github.com/gazebosim/gz-cmake/blob/gz-cmake3_3.4.0/cmake/FindJSONCPP.cmake#L39, and vcpkg explicitly does not install .pc files for jsoncpp, see

-DJSONCPP_WITH_PKGCONFIG_SUPPORT=OFF
. However, the .pc installation in jsoncpp was disabled in 2017 in c2efba6, long before all the great work to fully support .pc files in vcpkg, that was added in 2020 (see #9861). So I guess the easiest option is to enable .pc installation in jsoncpp, eventually adding a call to vcpkg_fixup_pkgconfig if necessary.

@talregev
Copy link
Contributor Author

Thank you! that was helping! I will update it on other PR that I have.

@talregev talregev closed this Sep 25, 2023
@talregev
Copy link
Contributor Author

I update it here.
@traversaro Thank you for your help!

#33919

@talregev talregev changed the title [Help needed][gz-cmake3] Update to 3.4.0 [gz-cmake3] Update to 3.4.0 Sep 26, 2023
@talregev talregev reopened this Sep 26, 2023
@talregev
Copy link
Contributor Author

My other PR is on hold, So I repoen this.
@Adela0814 @MonicaLiu0311
Please review this PR.

@talregev talregev marked this pull request as ready for review September 26, 2023 22:01
@MonicaLiu0311 MonicaLiu0311 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 27, 2023
@talregev talregev closed this Sep 27, 2023
@talregev talregev reopened this Oct 9, 2023
@talregev talregev mentioned this pull request Oct 9, 2023
11 tasks
@talregev talregev force-pushed the TalR/gz-cmake branch 2 times, most recently from 1829578 to 9b06087 Compare October 10, 2023 04:36
ports/gz-cmake3/portfile.cmake Outdated Show resolved Hide resolved
ports/jsoncpp/portfile.cmake Show resolved Hide resolved
@talregev
Copy link
Contributor Author

talregev commented Oct 11, 2023

@MonicaLiu0311 Thank you for your approval.
Who can add the label reviewed?

@MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 Thank you for your approval. Who can add the label reviewed?

If the CI Pipelines run pass, I will add the reviewed tag.

@talregev
Copy link
Contributor Author

@MonicaLiu0311 CI passed.

@MonicaLiu0311 MonicaLiu0311 added the info:reviewed Pull Request changes follow basic guidelines label Oct 12, 2023
@MonicaLiu0311 MonicaLiu0311 self-assigned this Oct 12, 2023
@BillyONeal BillyONeal merged commit 98da1aa into microsoft:master Oct 13, 2023
@BillyONeal
Copy link
Member

Thanks for the update!

@talregev talregev deleted the TalR/gz-cmake branch October 13, 2023 04:54
clementperon pushed a commit to clementperon/vcpkg that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants