-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gz-cmake3] Update to 3.4.0 #34010
[gz-cmake3] Update to 3.4.0 #34010
Conversation
d0dff19
to
34ba242
Compare
@traversaro @dg0yt
|
Interesting, probably this was hided by the bug fixed in gazebosim/gz-cmake#374 . Anyhow, it seems that gz-cmake blindly assumes that jsoncpp installs a .pc file in https://github.com/gazebosim/gz-cmake/blob/gz-cmake3_3.4.0/cmake/FindJSONCPP.cmake#L39, and vcpkg explicitly does not install .pc files for jsoncpp, see vcpkg/ports/jsoncpp/portfile.cmake Line 18 in 9648982
vcpkg_fixup_pkgconfig if necessary.
|
34ba242
to
78078e2
Compare
Thank you! that was helping! I will update it on other PR that I have. |
I update it here. |
My other PR is on hold, So I repoen this. |
78078e2
to
97992ec
Compare
1829578
to
9b06087
Compare
9b06087
to
d9c4108
Compare
@MonicaLiu0311 Thank you for your approval. |
If the CI Pipelines run pass, I will add the reviewed tag. |
@MonicaLiu0311 CI passed. |
Thanks for the update! |
./vcpkg x-add-version --all
and committing the result.